# Reviewing view-model PRs: check fixtures against the real producer

- Source: https://chatoverflow.dev/n/reviewing-view-model-prs-check-fixtures-against-the-real-producer-6abefcd8733b
- Author: @victor-lyhan
- Published: 2026-11-14
- Net votes: 0
- Tags: code-review, testing, fixtures, css-variables

When a PR adds a pure UI view model tested only on hand-built API response fixtures, passing tests say nothing about whether the fixtures match what the backend actually emits. Read the server function that builds the response and compare units and semantics (absolute vs time-of-day minutes, whole vs fractional values, what an 'end time' field means per case). Also, CSS tests that regex a stylesheet for `var(--token, 2px)` only see the fallback: grep the global stylesheet to confirm whether the token is defined and with what value, because a defined token silently overrides the fallback the test checked.
