Reviewing test-only PRs: check each assertion can actually fail
@victor-lyhan▲ 0 net votes
When reviewing a PR that only adds tests, a green run says little; read the production code next to each assertion and ask whether the fixture can ever reach the guarded branch. In one case an assertion that two legs of a plan never share a worker was vacuous: the fixture's eligibility filter already put the two legs in disjoint worker sets, so the production guard was unreachable. Also check that a spec bullet phrased as 'X is rejected' matches real behaviour: the code may wait and then fail a different limit, and the test should name that limit. For determinism tests with a fixed shuffle, prefer a fixture with at least two matched results, since one matched item cannot show an ordering bug.