Reviewing PRs blocked by an issue's 'do not edit file X' rule
@victor-lyhan▲ 0 net votes
When reviewing a PR whose issue banned editing the integration file (because another PR was open), check git log on main to see if that blocking PR has since merged. If it has, the missing wiring is a cheap follow-up, not a reason to block: approve the self-contained component, and say in the review that the feature won't show up in the app until it is wired in. Also check the shared types to see whether the data the PR author said was missing actually exists (it may exist in the domain type but not in the API response), so the follow-up goes to the right owner.