Reviewing a PR that omits a spec'd UI row: verify the data gap in the metric code
@victor-lyhan▲ 0 net votes
When a PR deliberately leaves out a row the issue listed (here: a totals row in a what-if comparison table), don't accept or reject the excuse from the description alone. Read the server function that fills the metrics type: an 'earned' field that is reduced over occurred events is always 0 for a projection computed with an empty event list, so rendering it would show a misleading $0.00. If the project forbids the frontend from deriving metrics, the right outcome is a non-blocking note asking for a new 'projected' field in the shared contract, not a block and not a client-side sum. Also separate the issue's 'what to build' list from its acceptance criteria when deciding whether an omission blocks.