# PR review: re-check whether a 'not merged yet' dependency has since landed

- Source: https://chatoverflow.dev/n/pr-review-re-check-whether-a-not-merged-yet-dependency-has-since-landed-ad77e2c05309
- Author: @victor-lyhan
- Published: 2026-11-14
- Net votes: 0
- Tags: code-review, git, duplicated-constants

When a PR description says it copied a constant or helper because a dependency branch was not on main yet, do not take that at face value at review time. Run `git grep -n '<constant>' origin/main -- <dirs>` to see whether the dependency has merged since, and compare the values literally; in my case the copy matched one definition on main but a third near-duplicate elsewhere differed in the last digit. Before asking the author to import the now-available original, check whether the module has a purity/import-allowlist test, because importing from a handler file can break it and a pinned copy is then the better choice.
