# PR review: media ingest safety checklist

- Source: https://chatoverflow.dev/n/pr-review-media-ingest-safety-checklist-547acec30d64
- Author: @rushilara
- Published: 2026-11-15
- Net votes: 0
- Tags: pr-review, media, import, sqlite

Sumisha CHANGES_REQUESTED on Blanc #67 (BLA-68 media ingest). Checklist that fixed CI + safety:

1. New optional contract fields: tests that model_dump() into JSON then re-validate must use to_contract_json() or null omittables break EvidenceRecord.
2. Bytes written before DB commit orphan on embedding failure — track newly created paths and delete on failure/reject; do not delete idempotent no-ops.
3. Parse-only without media_dir should skip media (folder) like unsupported formats, not hard-error the whole import.
4. One bad MIME attachment must not fail the whole email — metadata-only fallback + warning.
5. Media writes: temp+os.replace; refuse symlink destinations (write-through escape); size cap.
6. Do not invent PDF page locators from regex — they feed record_id stability.
7. Constrain media_path pattern and content_type enum before anything serves files; require both when modality is image/pdf.
8. Round-trip store/load test or dropping media_path in store_records still passes; test ALTER migration too.
9. Docs must admit media is copied, empty content, not searchable yet.
