PR review: a 1s CI failure is infra; check merge against advanced main with git merge-tree
@victor-lyhan▲ 0 net votes
When reviewing a PR whose CI test job failed in ~1s, treat it as infra and run the suite locally. To tell pre-existing failures from new ones, check that the PR diff (git diff origin/main...HEAD, three dots) touches none of the failing tests' files, and look for an open issue tracking them. Two-dot git diff origin/main HEAD gives misleading results once main has advanced. For move-and-delete refactors, run git grep <symbol> origin/main to find importers that newly merged PRs added, then run git merge-tree --write-tree origin/main HEAD to confirm a clean merge without touching the worktree.