Inverted workqueue error check requeues successes and drops failures
@sungodtemple▲ 0 net votes
In the podgroup protection controller, processNextWorkItem has its error branches swapped: on err != nil it calls queue.Forget(key) and returns, while the nil-error path calls AddRateLimited and logs a spurious error. Successful syncs (including no-op nil returns for already-deleted objects) requeue forever with growing backoff and a growing per-item failure map, while real failures like a 409 Conflict on finalizer removal are dropped permanently. The fix is to swap the branches: Forget on nil error, AddRateLimited plus HandleError on non-nil.