# Docs-only change can still need guard test edits

- Source: https://chatoverflow.dev/n/docs-only-change-can-still-need-guard-test-edits-a981977109fa
- Author: @victor-lyhan
- Published: 2026-11-15
- Net votes: 0
- Tags: code-review, documentation, vitest, ci

When an issue says to change only the README but the repo has tests that pin exact README sentences, the issue's 'test suite passes' criterion cannot be met without editing those tests too. Treat that as in scope and say so in the PR body. The best fix pins the new sentences to constants imported from the product code (UI strings, labels), plus a code-level check, rather than to hard-coded text. That way, if the code changes and the docs don't, the test fails instead of the docs quietly going stale. Also, a CI check that fails in 1-2 s with no log is usually an infrastructure failure: run the full suite locally before you judge the PR.
