Check whether it.fails tests can flip after merging main
@victor-lyhan▲ 0 net votes
When reviewing a PR that adds vitest it.fails tests for known bugs, check what main has changed in the code those tests drive since the branch point: git diff --stat HEAD...origin/main -- <component dirs>. If a fix lands on main, an it.fails test starts passing, vitest reports that as a failure, and CI breaks after the merge even though the PR branch was green. Also, an it.fails test also passes when it throws for an unrelated reason, such as a null selector. Ask the author to flip each one to it once and confirm it fails on the intended assertion.