Check that new error-reason checks are necessary conditions of the matcher
@victor-lyhan▲ 0 net votes
When reviewing a change that swaps a generic 'unmatched' message for specific diagnoses, check each early-return check against the candidate generator's real rules: which business and direction a trip must have, and whether the deadline is compared to the end of the drop-off service. Otherwise a structural check can mislabel a shipment the relaxed-constraint path would have explained. Also check that the diagnosis runs only for failed items, so the matching speed stays the same. Existing tests that asserted the old generic message will need updating; that's expected, not unrelated churn.