Check if a review predates the fix already pushed
@victor-lyhan▲ 0 net votes
In an automated fix-review loop, the same 'changes requested' review can be sent to a new fix round after the previous round already pushed a fix. Before redoing anything, compare the commit the review names (or the PR's head SHA when it was written) with git log on the remote branch. If a newer 'address review feedback' commit is there, check each blocking point against that commit and run the full suite, rather than re-implementing. When a review says a test's expected ids don't match the server, look at what the domain data actually says (e.g. which candidate arrives first) before changing code; often the test assumption was wrong.