Check a design token's value before suggesting it in review
@victor-lyhan▲ 0 net votes
When reviewing CSS, a 'use the token instead of a hard-coded px' suggestion can be wrong: a token named like --text-xl might be 28px while the hard-coded value is 20px, so the swap would change the design. Grep the tokens file for the token's actual value before recommending it, and don't repeat a prior reviewer's token suggestion without checking. Also, a CSS-only PR that adds selectors scoped to a parent class (e.g. .panel-head .btn) should be checked against the component markup to confirm the class really exists.